Queue cannot be created with redis config as string

[ales-albert-kilbergr]

Description

Queue object cannot be created with options.redis as string any more. Which has been possible in version 3.23.0

Minimal, Working Test code to reproduce the issue.

The change causing the change of behavior lays here:

v3.23.3...v3.25.0 in Queue.js line 280

The @types/bull library declares redis property as: Redis.RedisOptions | string | undefined; but the Queue.js:280 by using _.assign(...) breaks the string into an object. The difference between both versions (3.23.0 - 3.25.0) looks then like this:

//@v3.23.0
redis://@foo:6379

//@v3.25.0
{
      '0': 'r',
      '1': 'e',
      '2': 'd',
      '3': 'i',
      '4': 's',
      '5': ':',
      '6': '/',
      '7': '/',
      '8': '@',
      '9': 'f',
      '10': 'o',
      '11': 'o',
      '12': ':',
      '13': '6',
      '14': '3',
      '15': '7',
      '16': '9',
      connectionName: 'bull:dGVzdFF1ZXVl'
    }

Bull version

3.23.0 vs 3.25.0

Additional information

[ales-albert-kilbergr]

https://github.com/nestjs/bull/issues/869

[manast]

This was actually an undocumented feature that should not be possible in the first place, please see this: #2116
But if there are external llibraries depending on bull that use this approach it may be worth fixing it.

[eliotik]

Not only external libraries can be a problem but how do you suppose to split url provisioned to environment to host, port, password, username?

[manast]

@eliotik you just pass the "host" option like you do in ioredis: https://github.com/luin/ioredis/blob/master/API.md#new-redisport-host-options

[manast]

@eliotik or well, maybe I do not understand what you mean... you can either pass the url as a string and/or you pass an options object with whatever options you need. What you cannot do is passing a string with options attached to it, which imho seems like an antipattern to me.

[eliotik]

@eliotik you just pass the "host" option like you do in ioredis: https://github.com/luin/ioredis/blob/master/API.md#new-redisport-host-options

not exactly. host is url where redis is located, like boomboom.com.
what you actually use is a fully loaded parametrized url:
redis://username:yourfancypassword@host:port/dbid
so you cannot just take this string and define it as a value for host, or you can? :)

[manast]

@eliotik I think you are misunderstanding the issue. You can still do: new Queue(queueName, 'redis://username:yourfancypassword@host:port/dbid', otherRedisOpts);

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.