Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

BUILDER> Editing intent's name in the intent admin not working #113

Open
ghost opened this issue Nov 8, 2018 · 6 comments
Open

BUILDER> Editing intent's name in the intent admin not working #113

ghost opened this issue Nov 8, 2018 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Nov 8, 2018

CURRENTLY :
capture d ecran 2018-11-08 a 11 17 53
Editing intent's name directly in intent is not working

@ghost ghost added the bug Something isn't working label Nov 8, 2018
@lodelestra lodelestra added the good first issue Good for newcomers label Nov 13, 2018
@lodelestra
Copy link
Contributor

lodelestra commented Nov 13, 2018

It should be an inline edit, as in dashboard.

screen shot 2018-11-13 at 15 49 15

@jeffladiray
Copy link
Contributor

@arnaud-moncel, @damien-citaire
After digging, https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L431 should be replaced by a TextField, especially if we want the same behaviour between dashboard page and builder page.

We're actually facing an issue. Current rename behavior on the left panel (Intent section) should not be modified: since single click on an intent actually display it on the center panel, click-to-edit shouldn't be used. That implies that Zrmc.showDialog should be kept on the left menu. In order to avoid different behavior for the same feature, we suggest implementing the same behavior from the left column.

@lodelestra
Copy link
Contributor

Ok, thanks.
{name} is from
https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L403-L407
and intent.name from
https://github.com/Opla/opla/blob/2928bfd4fca32037dec2949cd81ee5835f3b2eb8/front/src/shared/containers/builder/intentContainer.jsx#L396

It's look like it's state dependent. Maybe we can store the editing version in state, en sync it with the redux store on Save click or focus out ? What do you think ?

@damien-citaire
Copy link
Contributor

We can make that. But as we said it in the previous message, it would give two different behavior for the same feature. Wouldn't it be better to put the behavior of the left column in center column in a view of harmonization?

@lodelestra
Copy link
Contributor

Thanks Damien,
In the future the possibility to edit the intent name from the intent list on the left (via a dialog) will be removed, and intent will be only editable from its details view displayed inside the center panel.
The left pannel with intent list is in active developpement right now, removing the editing on this part will be another issue.

To sum up we want to add inline editing for the intent name in center panel (intent ), and remove the dialog editing later.

@E1000y
Copy link
Contributor

E1000y commented Mar 1, 2019

We still have issues while trying to edit first intent's name.

capture d ecran 2019-03-01 a 16 10 21

Pencil obviously not working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants