Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer): Reduce size of protocol JSON file #6231

Closed
amitlissack opened this issue Jul 29, 2020 · 0 comments
Closed

feat(protocol-designer): Reduce size of protocol JSON file #6231

amitlissack opened this issue Jul 29, 2020 · 0 comments

Comments

@amitlissack
Copy link
Contributor

As part of fixing this #6159 I looked at the bug attached JSON protocol to see why it was so big.

It has 3693 commands. Each command has two rather long string fields which constitute more than half the size of the JSON protocol:

  • params.pipette which is a UUID (36 chars)
  • params.labware which is a UUID concatenated with a name (100+ chars)

Even though the example is absurdly large, there are benefits to reducing the size of these fields: upload time, memory consumption, json parse time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amitlissack