From b462aaf02d5aadbf7ef0dbd107673174001c0708 Mon Sep 17 00:00:00 2001
From: Brayan Almonte <vegano1@users.noreply.github.com>
Date: Fri, 6 Sep 2024 14:40:36 -0400
Subject: [PATCH] fix(app): Don't initialize the keyboard with an invalid value
 when creating Quick Transfer protocols. (#16203)

---
 .../QuickTransferFlow/QuickTransferAdvancedSettings/AirGap.tsx | 2 +-
 .../QuickTransferFlow/QuickTransferAdvancedSettings/Delay.tsx  | 3 ++-
 .../QuickTransferAdvancedSettings/FlowRate.tsx                 | 2 +-
 .../QuickTransferFlow/QuickTransferAdvancedSettings/Mix.tsx    | 2 +-
 .../QuickTransferAdvancedSettings/PipettePath.tsx              | 2 +-
 .../QuickTransferAdvancedSettings/TipPosition.tsx              | 2 +-
 .../QuickTransferAdvancedSettings/TouchTip.tsx                 | 2 +-
 7 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/AirGap.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/AirGap.tsx
index 3e0982ed659..ee0bd2f895d 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/AirGap.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/AirGap.tsx
@@ -220,7 +220,7 @@ export function AirGap(props: AirGapProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
-              initialValue={String(volume)}
+              initialValue={String(volume ?? '')}
               onChange={e => {
                 setVolume(Number(e))
               }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Delay.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Delay.tsx
index d51129850be..75276350458 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Delay.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Delay.tsx
@@ -237,6 +237,7 @@ export function Delay(props: DelayProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
+              initialValue={String(delayDuration ?? '')}
               onChange={e => {
                 setDelayDuration(Number(e))
               }}
@@ -277,7 +278,7 @@ export function Delay(props: DelayProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
-              initialValue={String(position)}
+              initialValue={String(position ?? '')}
               onChange={e => {
                 setPosition(Number(e))
               }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/FlowRate.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/FlowRate.tsx
index f7d6dfcede0..a5fb6c7eb78 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/FlowRate.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/FlowRate.tsx
@@ -150,7 +150,7 @@ export function FlowRateEntry(props: FlowRateEntryProps): JSX.Element {
         >
           <NumericalKeyboard
             keyboardRef={keyboardRef}
-            initialValue={String(flowRate)}
+            initialValue={String(flowRate ?? '')}
             onChange={e => {
               setFlowRate(Number(e))
             }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Mix.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Mix.tsx
index ddc6b55ef59..f15323934ea 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Mix.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/Mix.tsx
@@ -217,7 +217,7 @@ export function Mix(props: MixProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
-              initialValue={String(mixVolume)}
+              initialValue={String(mixVolume ?? '')}
               onChange={e => {
                 setMixVolume(Number(e))
               }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/PipettePath.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/PipettePath.tsx
index 3bb48859603..0647a7806ba 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/PipettePath.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/PipettePath.tsx
@@ -215,7 +215,7 @@ export function PipettePath(props: PipettePathProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
-              initialValue={String(disposalVolume)}
+              initialValue={String(disposalVolume ?? '')}
               onChange={e => {
                 setDisposalVolume(Number(e))
               }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TipPosition.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TipPosition.tsx
index 4e3762a7d8b..4603f295a5c 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TipPosition.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TipPosition.tsx
@@ -141,7 +141,7 @@ export function TipPositionEntry(props: TipPositionEntryProps): JSX.Element {
         >
           <NumericalKeyboard
             keyboardRef={keyboardRef}
-            initialValue={String(tipPosition)}
+            initialValue={String(tipPosition ?? '')}
             onChange={e => {
               setTipPosition(Number(e))
             }}
diff --git a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TouchTip.tsx b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TouchTip.tsx
index 0010667afa6..95de3167aeb 100644
--- a/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TouchTip.tsx
+++ b/app/src/organisms/QuickTransferFlow/QuickTransferAdvancedSettings/TouchTip.tsx
@@ -209,7 +209,7 @@ export function TouchTip(props: TouchTipProps): JSX.Element {
           >
             <NumericalKeyboard
               keyboardRef={keyboardRef}
-              initialValue={String(position)}
+              initialValue={String(position ?? '')}
               onChange={e => {
                 setPosition(Number(e))
               }}