Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs/ot2_defconfig: select ca-certificates, curl, git, grep, sl, wget #86

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented May 27, 2020

overview

This PR adds some packages to the OT-2 defconfig to enable more complex workflows:

  • ca-certificates to make sure the robot has root certs to hit HTTPS stuff
  • git for pulling stuff from... git
  • curl and wget for making requests and pulling data from HTTP
  • grep for data and log inspection
  • sl to make @sfoster1 happy

review requests

  • can successfully clone a git repository via HTTPS
  • can curl an HTTPS endpoint
  • can wget an HTTPS resource
  • can grep something
  • chugga chugga choo choo

gnutls enables fetch of https urls with wget; git is useful for external
contributors adding more complex workflows.
@sfoster1 sfoster1 added the robot-svcs Robot Services label May 27, 2020
@sfoster1 sfoster1 requested review from a team, ahiuchingau, mcous and amitlissack and removed request for a team May 27, 2020 20:24
@theosanderson
Copy link
Contributor

theosanderson commented Jun 1, 2020

For info, I branched off this and I am not finding that this works:

# git remote add origin https://github.com/theosanderson/covid_serology_ot.git
# git push -u origin master
fatal: Unable to find remote helper for 'https'
# wget "https://bbcnews.com"
wget: not an http or ftp url: https://bbcnews.com
# 

Edit: possible this was a copy and paste problem with hidden characters, which I've since encountered. Sorry if this was a bad report!

@mcous mcous added the packages Ticket deals with adding or removing packages from the system label Jul 10, 2020
@mcous mcous changed the title config/ot2_defconfig: select git, gnutls configs/ot2_defconfig: select curl, git, grep, sl, wget Sep 15, 2020
@mcous mcous added the ready-for-review This PR is ready for review label Sep 15, 2020
@mcous mcous requested review from a team and removed request for ahiuchingau, mcous, amitlissack and a team September 15, 2020 17:27
@mcous mcous changed the title configs/ot2_defconfig: select curl, git, grep, sl, wget configs/ot2_defconfig: select ca-certificates, curl, git, grep, sl, wget Sep 15, 2020
Copy link
Member Author

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's technically still my own PR I can't approve, but I can confirm that git, curl, and wget from https endpoints works, as does the steam locomotive

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @sfoster1 per his comment above

@mcous mcous merged commit 019caba into opentrons-develop Sep 16, 2020
@mcous mcous deleted the add-git-tls branch September 16, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Ticket deals with adding or removing packages from the system ready-for-review This PR is ready for review robot-svcs Robot Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants