Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLAlchemy #151

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add SQLAlchemy #151

merged 3 commits into from
Apr 1, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Mar 29, 2022 •
edited
Loading

Overview

Companion PR to Opentrons/opentrons#9829

This PR adds SQLAlchemy to the robot's operating system.

@SyntaxColoring SyntaxColoring mentioned this pull request Mar 30, 2022
Merged
@mcous mcous force-pushed the sqlalchemy-prod-dep branch from 77946a0 to 62a0e35 Compare March 30, 2022 14:51
@mcous mcous changed the base branch from opentrons-develop to strip-numpy-pandas-tests March 30, 2022 14:52
@mcous mcous changed the base branch from strip-numpy-pandas-tests to opentrons-develop March 30, 2022 14:52
This was referenced Mar 30, 2022
Merged
Merged
@mcous mcous force-pushed the sqlalchemy-prod-dep branch from 62a0e35 to e83598f Compare March 30, 2022 23:13
@mcous mcous force-pushed the sqlalchemy-prod-dep branch from e83598f to b21ce6d Compare March 30, 2022 23:23
@mcous mcous marked this pull request as ready for review March 31, 2022 00:40
@mcous
Copy link
Contributor Author

mcous commented Mar 31, 2022

Tested on a Raspberry Pi. Using the Python REPL onboard, I was able to:

>>> import sqlalchemy
>>> sqlalchemy.__version__
'1.4.32'

@mcous mcous requested review from sfoster1, a team and sanni-t and removed request for a team March 31, 2022 16:53
SyntaxColoring
SyntaxColoring approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to merge if this has been tested on a robot!

sanni-t
sanni-t approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if it works on a robot!

y3rsh
y3rsh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my robot.

@mcous mcous merged commit d260790 into opentrons-develop Apr 1, 2022
@mcous mcous deleted the sqlalchemy-prod-dep branch April 1, 2022 14:19
@SyntaxColoring SyntaxColoring mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanni-t sanni-t sanni-t approved these changes

@SyntaxColoring SyntaxColoring SyntaxColoring approved these changes

@y3rsh y3rsh y3rsh approved these changes

@sfoster1 sfoster1 Awaiting requested review from sfoster1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcous @y3rsh @SyntaxColoring @sanni-t