-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove several unused packages #143
Conversation
Sorry, Seth.
Ideas for further work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but I think there's more we can do like,
- Strip out all the bluetooth stuff. this was a temporary experiment that at this point I think is not going to happen
- if busybox has a curl let's use that; wget can still be useful, but i don't really care whether it happens or not
- i do not remember at all why we added git, let's not
- i doubt we need screen or tmux but they're also tiny so whatever
Stripping as much non-critical content from the python stuff is absolutely a good idea. We may also find it useful to install them as gzipped wheels to save disk space.
@@ -91,7 +85,29 @@ BR2_PACKAGE_DROPBEAR=y | |||
BR2_PACKAGE_IW=y | |||
BR2_PACKAGE_NETWORK_MANAGER=y | |||
BR2_PACKAGE_NGINX=y | |||
BR2_PACKAGE_NGINX_HTTP_SSL_MODULE=y | |||
# BR2_PACKAGE_NGINX_HTTP_CHARSET_MODULE is not set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, stuff like this usually doesn't make it into a defconfig, wonder if nginx is doing something weird to parse these. would expect them to be BR2_PACKAGE_NGINX_HTTP_GZIP_MODULE=n
and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is weird and mysterious.
Aggregating those further ideas in #144. |
Overview
These commits deselect a bunch of unused packages in an attempt to free up some filesystem space. (See Opentrons/opentrons#8184.)
Unfortunately, I still don't think this is enough for a top-level
make push
to succeed, so Opentrons/opentrons#8184 will stay open.Changelog
chardet
, a dependency of this.pyserial-asyncio
. I couldn't find any instance ofimport serial_asyncio
in Opentrons/opentrons.json-c
, a library that isn't mandated by anything else that we have installed.nginx.conf
.sl
. 😢Review requests
Do any of the removed packages strike you as something that we should definitely not remove?