Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: UpgradeableBeacon incorrectly detected as upgradeable implementation #849

Closed
ericglau opened this issue Jul 24, 2023 · 1 comment · Fixed by #1065
Closed

CLI: UpgradeableBeacon incorrectly detected as upgradeable implementation #849

ericglau opened this issue Jul 24, 2023 · 1 comment · Fixed by #1065

Comments

@ericglau
Copy link
Member

UpgradeableBeacon is incorrectly detected as an upgradable implementation because it has a function with signature upgradeTo(address), which causes it to "look" like a UUPS implementation, even though this function is for the beacon itself and not related to UUPS.

Steps to reproduce:

  1. Install https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/ using Foundry
  2. Run upgrades core CLI
  3. The following error occurs:
lib/openzeppelin-contracts/contracts/proxy/beacon/UpgradeableBeacon.sol:UpgradeableBeacon

      lib/openzeppelin-contracts/contracts/proxy/beacon/UpgradeableBeacon.sol:31: Contract `UpgradeableBeacon` has a constructor
          Define an initializer instead
          https://zpl.in/upgrades/error-001
      
      lib/openzeppelin-contracts/contracts/access/Ownable.sol:38: Contract `Ownable` has a constructor
          Define an initializer instead
          https://zpl.in/upgrades/error-001
@Ramarti
Copy link

Ramarti commented Mar 22, 2024

+1 to this, I need to call npx @openzeppelin/upgrades-core@^1.32.3 validate from a GHA and this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants