Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Remove babel from CLI #907

Closed
spalladino opened this issue May 23, 2019 · 0 comments · Fixed by #909
Closed

Remove babel from CLI #907

spalladino opened this issue May 23, 2019 · 0 comments · Fixed by #909
Labels
kind:enhancement Enhancement to an existing feature

Comments

@spalladino
Copy link
Contributor

The CLI depends on web3-provider-engine, which requires json-rpc-engine, which bundles babel as dependency.

We are currently using web3-provider-engine only to manually inject a NonceTracker to an hdwallet-provider if present, due to this issue. See #586 for a recent occurrence of that problem in zos.

See if we can work this around by including only what we strictly need from provider-engine, to avoid importing json-rpc-engine at all. Another option would be to check if the issue in hdwallet-provider is fixed, and just suggest our users to upgrade if we detect they are using an old version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant