Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot derivation library #4975

Merged
merged 14 commits into from
Mar 27, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 26, 2024

This takes the non-controversial part of #4965, while we figure out how we want to handle transiant storage.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx requested a review from ernestognw March 26, 2024 20:20
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 3b60f2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx
Copy link
Collaborator Author

Amxx commented Mar 27, 2024

We used to have codecov actions, but they don't show up anymore

contracts/utils/StorageSlot.sol Outdated Show resolved Hide resolved
contracts/utils/SlotDerivation.sol Show resolved Hide resolved
scripts/generate/templates/SlotDerivation.js Show resolved Hide resolved
scripts/generate/templates/SlotDerivation.js Show resolved Hide resolved
scripts/generate/templates/SlotDerivation.js Outdated Show resolved Hide resolved
scripts/generate/templates/SlotDerivation.js Outdated Show resolved Hide resolved
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the docs including examples for both SlotDerivation and StorageSlot (and Merkle Tree, je).

I'd like to reconsider exposing the erc1967Slot

contracts/utils/SlotDerivation.sol Outdated Show resolved Hide resolved
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants