-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slot derivation library #4975
Add slot derivation library #4975
Conversation
🦋 Changeset detectedLatest commit: 3b60f2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We used to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved the docs including examples for both SlotDerivation and StorageSlot (and Merkle Tree, je).
I'd like to reconsider exposing the erc1967Slot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
This takes the non-controversial part of #4965, while we figure out how we want to handle transiant storage.
PR Checklist
npx changeset add
)