Add an internal _setApprovalForAll function (721 & 1155) #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
force-pushed
the
feature/_setApprovalForAll
branch
from
89fe594
to
7a1a8ae
Compare
frangio
reviewed
Sep 14, 2021
contracts/token/ERC1155/ERC1155.sol
Outdated
| address operator, | ||
| bool approved | ||
| ) internal virtual { | ||
| // TODO: add sanity checks? |
There was a problem hiding this comment.
What checks did you have in mind?
There was a problem hiding this comment.
possibly require(owner != operator) ... but I was not really sure
There was a problem hiding this comment.
I agree with adding that require statement. We should move the one in the external function into the internal function.
Note: This PR is also pending a changelog entry.
3 tasks
frangio
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832
PR Checklist