Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier & internal function with standard revert message in AccessControl #2609

Merged
merged 18 commits into from
Apr 16, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 23, 2021

Fixes #2601

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx force-pushed the feature/AccessControlRevertMessage branch from e1fc49b to 68af355 Compare March 23, 2021 15:23
@Amxx Amxx force-pushed the feature/AccessControlRevertMessage branch from 68af355 to 401b419 Compare March 23, 2021 15:29
frangio
frangio previously approved these changes Apr 12, 2021
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@frangio frangio merged commit e0a2b19 into OpenZeppelin:master Apr 16, 2021
@Amxx Amxx deleted the feature/AccessControlRevertMessage branch April 16, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hint at missing role in revert reason for AccessControl rejection
2 participants