Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use invalid opcode in MinimalForwarder #2864

Closed
frangio opened this issue Sep 15, 2021 · 0 comments · Fixed by #3035
Closed

Use invalid opcode in MinimalForwarder #2864

frangio opened this issue Sep 15, 2021 · 0 comments · Fixed by #3035

Comments

@frangio
Copy link
Contributor

frangio commented Sep 15, 2021 •
edited
Loading

Since Solidity 0.8.0 assert no longer triggers an invalid opcode, but uses revert. MinimalForwarder should use invalid opcode to consume all gas as a protection for "insufficient gas griefing attack" as described in this article.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use invalid opcode to consume all gas in MinimalForwarder Amxx/openzeppelin-contracts
1 participant
@frangio