Fix network handling

src/nile/common.py

@@ -28,25 +28,31 @@
     # subject to change
     "0x041a78e741e5af2fec34b695679bc6891742439f7afb8484ecd7766661ad02bf"
 )
+DEFAULT_GATEWAYS = {
+    "goerli2": "https://alpha4-2.starknet.io",
+    "integration": "https://external.integration.starknet.io",
+}
 
 
 def get_gateways():
     """Get the StarkNet node details."""
     try:
         with open(NODE_FILENAME, "r") as f:
             gateway = json.load(f)
-            return gateway
-
+            gateways = {**gateway, **DEFAULT_GATEWAYS}
+            return gateways
     except FileNotFoundError:
-        with open(NODE_FILENAME, "w") as f:
-            networks = {
-                "localhost": "http://127.0.0.1:5050/",
-                "goerli2": "https://alpha4-2.starknet.io",
-                "integration": "https://external.integration.starknet.io",
-            }
-            f.write(json.dumps(networks, indent=2))
-
-            return networks
+        gateway = create_node_json()
+        gateways = {**gateway, **DEFAULT_GATEWAYS}
+        return gateways
+
+
+def create_node_json(network="localhost", gateway_url="http://127.0.0.1:5050/"):
+    """Create node.json and return gateways."""
+    with open(NODE_FILENAME, "w") as f:
+        gateway = {network: gateway_url}
+        f.write(json.dumps(gateway))
+        return gateway
 
 
 GATEWAYS = get_gateways()

src/nile/core/node.py

@@ -1,25 +1,20 @@
 """Command to start StarkNet local network."""
-import json
 import logging
 import subprocess
 
-from nile.common import NODE_FILENAME
+from nile.common import create_node_json
 
 
 def node(host="127.0.0.1", port=5050, seed=None, lite_mode=False):
     """Start StarkNet local network."""
     try:
         # Save host and port information to be used by other commands
-        file = NODE_FILENAME
         if host == "127.0.0.1":
             network = "localhost"
         else:
             network = host
         gateway_url = f"http://{host}:{port}/"
-        gateway = {network: gateway_url}
-
-        with open(file, "w+") as f:
-            json.dump(gateway, f)
+        create_node_json(network, gateway_url)
 
         command = ["starknet-devnet", "--host", host, "--port", str(port)]
 

tests/test_common.py

@@ -1,7 +1,18 @@
 """Tests for common library."""
+import json
+from unittest.mock import mock_open, patch
+
 import pytest
 
-from nile.common import parse_information, prepare_params, stringify
+from nile.common import (
+    DEFAULT_GATEWAYS,
+    NODE_FILENAME,
+    create_node_json,
+    get_gateways,
+    parse_information,
+    prepare_params,
+    stringify,
+)
 
 NETWORK = "goerli"
 ARGS = ["1", "2", "3"]
@@ -10,6 +21,7 @@
 LIST3 = [1, 2, 3, [4, 5, 6, [7, 8, 9]]]
 STDOUT_1 = "SDTOUT_1"
 STDOUT_2 = "SDTOUT_2"
+LOCAL_GATEWAY = {"localhost": "http://127.0.0.1:5050/"}
 
 
 @pytest.mark.parametrize(
@@ -48,3 +60,38 @@ def test_parse_information():
 
     _a, _b = parse_information(target)
     assert _a, _b == (a, b)
+
+
+def test_get_gateways():
+    gateways = get_gateways()
+    expected = {**LOCAL_GATEWAY, **DEFAULT_GATEWAYS}
+    assert gateways == expected
+
+    # Check create_node_json is called with FileNotFoundError
+    with patch(
+        "nile.common.create_node_json", return_value=LOCAL_GATEWAY
+    ) as mock_create:
+        open_mock = mock_open()
+        with patch("nile.common.open", open_mock):
+            open_mock.side_effect = FileNotFoundError
+            gateways = get_gateways()
+
+            mock_create.assert_called_once()
+            assert gateways == expected
+
+
+@pytest.mark.parametrize(
+    "args, gateway", [(None, LOCAL_GATEWAY), (["a", "b"], {"a": "b"})]
+)
+def test_create_node_json(args, gateway):
+    open_mock = mock_open()
+    with patch("nile.common.open", open_mock, create=True):
+        if args is None:
+            create_node_json()
+        else:
+            create_node_json(*args)
+
+    expected = json.dumps({**gateway})
+
+    open_mock.assert_called_with(NODE_FILENAME, "w")
+    open_mock.return_value.write.assert_called_once_with(expected)