Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Improve error bubbling #117

Open
martriay opened this issue May 9, 2022 · 1 comment
Open

Improve error bubbling #117

martriay opened this issue May 9, 2022 · 1 comment
Milestone

Comments

@martriay
Copy link
Contributor

martriay commented May 9, 2022

As seen in many issues as #108, when there's an upstream error in Nile (e.g. when the underlying command such as starknet or starknet-devnet fails), the output is very obscure about the reasons of the error.

Fix nile so it propagates the error message and help users troubleshoot nile.

@fracek
Copy link
Contributor

fracek commented May 10, 2022

I think the way to do this is by capturing the subprocess output (should we differentiate stdout and stderr with e.g. color?), capture any exception to suppress the default python stacktrace and simply inform the user something went wrong. I believe we have no way to know exactly went wrong in the subprocess to display more information about it.

@martriay martriay added this to the next milestone Jul 4, 2022
@martriay martriay moved this to 📋 Backlog in Cairo team Jul 4, 2022
@martriay martriay moved this from 📋 Backlog to 🏗 In progress in Cairo team Aug 1, 2022
@martriay martriay moved this from 🏗 In progress to 👀 In review in Cairo team Aug 3, 2022
@martriay martriay moved this from 👀 In review to ✅ Resolved in Cairo team Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants