Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DualDispatchers #1128

Closed
5 of 6 tasks
ggonzalez94 opened this issue Sep 4, 2024 · 0 comments · Fixed by #1163
Closed
5 of 6 tasks

Remove DualDispatchers #1128

ggonzalez94 opened this issue Sep 4, 2024 · 0 comments · Fixed by #1163
Assignees
@ericnordelo
Milestone
1. current

Comments

@ggonzalez94
Copy link
Collaborator

ggonzalez94 commented Sep 4, 2024 •
edited by ericnordelo
Loading

🧐 Motivation
They are not supported on live networks and make our library more blotted.

📝 Details
We've had DualDispatchers for a while now, and since they are not supported on live networks they haven't been adopted. They are an additional liability in our codebase and make the amount of LOC bigger for any security review.

Tasks
Preview Give feedback
@ggonzalez94 ggonzalez94 added the needs discussion This still needs discussion or research before deciding if it should be implemented label Sep 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Sep 4, 2024
@ggonzalez94 ggonzalez94 removed the needs discussion This still needs discussion or research before deciding if it should be implemented label Sep 17, 2024
@ggonzalez94 ggonzalez94 added this to the 2. next milestone Sep 17, 2024
@ericnordelo ericnordelo self-assigned this Sep 20, 2024
This was referenced Sep 25, 2024
Merged
Merged
This was referenced Oct 2, 2024
Closed
Merged
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
1. current
Development

Successfully merging a pull request may close this issue.

Remove DualCase dispatchers OpenZeppelin/cairo-contracts
2 participants
@ggonzalez94 @ericnordelo