env: do not recursively init XiangShan #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangShan contains multiple copies of rocket-chip, huancun, and other submodules in its submodule. If we execute `git submodule update --init --recursive` on XiangShan, we will get multiple copies of these modules and even have different versions. But in the mill file, we will only choose one to compile. This behavior will confuse the developers, and they need to exclude these modules when doing a full-text search on the XiangShan folder. But we can get this solved by not recursively init the XiangShan submodule.
cyyself
force-pushed
the
do-not-recursive-xs
branch
from
7878514 to
6601b60
Compare
chenguokai
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XiangShan contains multiple copies of rocket-chip, huancun, and other submodules in its submodule. If we execute
git submodule update --init --recursiveon XiangShan, we will get multiple copies of these modules and even have different versions. But in the mill file, we will only choose one to compile. This behavior will confuse the developers, and they need to exclude these modules when doing a full-text search on the XiangShan folder. But we can get this solved by not recursively init the XiangShan submodule.