Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Curtain scanDuration is less then updateRate, overriding scanDuration with updateRate #635

Closed
dnicolson opened this issue Dec 28, 2022 · 1 comment · Fixed by #661
Closed
Assignees
Labels
bug Something isn't working

Comments

@dnicolson
Copy link
Collaborator

dnicolson commented Dec 28, 2022

Describe The Bug

A scanDuration < updateRate warning is logged when default values are used, there is a second warning logged (https://github.com/OpenWonderLabs/homebridge-switchbot/blob/dc0ce6e/src/device/curtain.ts#L968) with the same message which looks like a mistake. There is a typo with "then" too.

To Reproduce

Start Homebridge

Expected behavior

No log warning

Relevant log output

[28/12/2022, 17:41:35] [SwitchBot] Curtain: Curtain scanDuration is less then updateRate, overriding scanDuration with updateRate
[28/12/2022, 17:41:35] [SwitchBot] Curtain: Curtain Config: {"set_min":10,"set_max":90,"hide_lightsensor":false,"set_minlux":1,"set_maxlux":6001,"connectionType":"BLE","logging":"standard","maxRetry":0}

Config for homebridge-switchbot

{
    "deviceId": "<id>",
    "configDeviceName": "Curtain",
    "configDeviceType": "Curtain",
    "connectionType": "BLE",
    "curtain": {
        "set_min": 10,
        "set_max": 90,
        "hide_lightsensor": false,
        "set_minlux": 1,
        "set_maxlux": 6001
    },
    "maxRetry": 0,
    "logging": "standard"
}

Screenshots

No response

Device & Model

SwitchBot Curtain W0701600

Node.js Version

v18.12.1

NPM Version

v8.19.2

Homebridge Version

v1.6.0

Homebridge Switchbot Plugin Version

v2.4.0

Homebridge Config UI X Plugin Version

v4.50.2

Operating System

Raspbian

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants