Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhacements to pyswmm.Simulation class #29

Merged
merged 3 commits into from
Feb 16, 2017
Merged

Conversation

bemcdonnell
Copy link
Member

Some more simulation class features have been added

@bemcdonnell bemcdonnell requested a review from goanpeca February 16, 2017 03:36
@bemcdonnell
Copy link
Member Author

This covers #27

@bemcdonnell
Copy link
Member Author

Also updated the README today.

pyswmm/pyswmm.py Outdated
self._model.swmmExec()

@property
def starttime(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_time ?

pyswmm/pyswmm.py Outdated
self._model.setSimulationDateTime(SimulationTime.StartDateTime, dtimeval)

@property
def endtime(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end_time?

pyswmm/pyswmm.py Outdated
self._model.setSimulationDateTime(SimulationTime.EndDateTime, dtimeval)

@property
def reportstart(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_start ?

pyswmm/pyswmm.py Outdated
self._model.setSimulationDateTime(SimulationTime.ReportStart, dtimeval)

@property
def flowunits(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flow_units ?

pyswmm/pyswmm.py Outdated
return self._model.getSimUnit(SimulationUnits.FlowUnits)

@property
def systemunits(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system_units?

@bemcdonnell bemcdonnell merged commit 9db40d7 into pyswmm:master Feb 16, 2017
@bemcdonnell bemcdonnell deleted the dev branch February 16, 2017 14:10
@goanpeca goanpeca modified the milestone: v0.3 Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants