-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhacements to pyswmm.Simulation class #29
Conversation
This covers #27 |
Also updated the README today. |
pyswmm/pyswmm.py
Outdated
self._model.swmmExec() | ||
|
||
@property | ||
def starttime(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start_time ?
pyswmm/pyswmm.py
Outdated
self._model.setSimulationDateTime(SimulationTime.StartDateTime, dtimeval) | ||
|
||
@property | ||
def endtime(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end_time?
pyswmm/pyswmm.py
Outdated
self._model.setSimulationDateTime(SimulationTime.EndDateTime, dtimeval) | ||
|
||
@property | ||
def reportstart(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
report_start ?
pyswmm/pyswmm.py
Outdated
self._model.setSimulationDateTime(SimulationTime.ReportStart, dtimeval) | ||
|
||
@property | ||
def flowunits(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flow_units ?
pyswmm/pyswmm.py
Outdated
return self._model.getSimUnit(SimulationUnits.FlowUnits) | ||
|
||
@property | ||
def systemunits(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system_units?
Some more simulation class features have been added