PySWMM v1.0 #262
Merged
PySWMM v1.0 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting minor typo in the tutorial document
…statistics function to be compatible with swmm-toolkit
bemcdonnell
approved these changes
Jan 5, 2021
| @@ -17,7 +17,8 @@ | |||
| from pyswmm.system import SystemStats | |||
| from pyswmm.raingages import RainGages, RainGage | |||
|
|
|||
| VERSION_INFO = (0, 6, 3, 'dev0') | |||
| VERSION_INFO = (1, 0, 0, 'dev0') | |||
There was a problem hiding this comment.
@jennwuu can you confirm the versions here?
There was a problem hiding this comment.
@bemcdonnell the SWMM version?
There was a problem hiding this comment.
@bemcdonnell @michaeltryby This version information should removed since swmm is from swmm-toolkit package
|
Please make sure to clearly note the deprecation of the DLL picker feature in the release notes |
michaeltryby
approved these changes
Jan 7, 2021
…gs in swmm-toolkit package
|
🎈🥳🎉 |
|
💃🕺💃🕺💃🕺💃🕺💃💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors pyswmm swmm5 module to use swmm-toolkit package to interact with model data from SWMM API. Moving forward, PySWMM is only compatible with Python 3+ 64bit.
Setup Github Action
Closes #263 The ability to use different SWMM .dll is also removed.
Closes #264 swmm5 module refactor
Closes #265 Repository cleanup