Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change single ptr struct to double ptr struct for ctypes for subcatch #212

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

jennwuu
Copy link
Contributor

@jennwuu jennwuu commented Oct 8, 2019

Closes #211

-Update subcatch_statistics from single ptr to double ptr
-Add an unit test
-TODO: should add a metric unit test in here..

units for the following variables:

  • precipitation [volume in depth] [in/mm]
  • runon [volume] [ft3/m3]
  • evaporation [volume] [ft3/m3]
  • infiltration [volume] [ft3/m3]
  • runoff [volume] [ft3/m3]
  • maxFlow [flow] [cfs/m3/s]
int DLLEXPORT swmm_getSubcatchStats(int index, SM_SubcatchStats **subcatchStats)
///
/// Output:  Subcatchment Stats Structure (SM_SubcatchStats)
/// Return:  API Error
/// Purpose: Gets Subcatchment Stats and Converts Units
{

Copy link
Member

@bemcdonnell bemcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennwuu, go ahead and merge code and release v0.5.2 (also close the milestone and issues associated). Sloth power

Copy link
Contributor

@katmratliff katmratliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennwuu!

@jennwuu jennwuu merged commit 24651d3 into master Oct 8, 2019
@jennwuu jennwuu deleted the bug branch October 8, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subcatchment.statistics not giving cumulative results
3 participants