Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Hooks for Callbacks #142

Merged
merged 9 commits into from
Dec 31, 2017
Merged

Added Hooks for Callbacks #142

merged 9 commits into from
Dec 31, 2017

Conversation

bemcdonnell
Copy link
Member

@bemcdonnell bemcdonnell commented Dec 30, 2017 •
edited
Loading

Closes #140
Closes #143

@bemcdonnell bemcdonnell added this to the v0.4.6 milestone Dec 30, 2017
@bemcdonnell bemcdonnell self-assigned this Dec 30, 2017
@bemcdonnell bemcdonnell requested a review from goanpeca December 30, 2017 19:04
@michaeltryby
Copy link
Contributor

I like this, but there is a lot of boilerplate repeated code for adding callbacks that could be eliminated.

@michaeltryby
Copy link
Contributor

I don't see value in checking for existence of callback using your getter. Should just check dictionary directly.

@michaeltryby
Copy link
Contributor

Looks good!

@bemcdonnell bemcdonnell merged commit 5c1f3f2 into pyswmm:master Dec 31, 2017
@bemcdonnell bemcdonnell deleted the callback_hooks branch December 31, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltryby michaeltryby michaeltryby approved these changes

@goanpeca goanpeca Awaiting requested review from goanpeca

Assignees

@bemcdonnell bemcdonnell

Labels
type:feature
Projects
None yet
Milestone
v0.4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@bemcdonnell @michaeltryby