-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make plug types (entrypoint groups) inventor agnostic #144
Comments
note that those are not the platform, OPM pugins all can be used standalone, those are the authors of the reference implementation, ie, who invented the base class its a namespace of the reference framework we ensure compatibility with, if we for example extend a class to become incompatible with mycroft we then would change the namespace from mycroft.xxx to ovos.xxx |
we should however for consistenct add
|
I just don't think it's the place for that. It is a group descriptor of the plugin type |
Furthermore, reading org discussion 142
indicating this is already planned as a package naming convention. This should also be reflected here. |
that convention would depend on buy in from the others cores and imply a large refactor across many repos across orgs ping @NeonDaniel |
I think it makes sense to standardize entrypoint names, but the main issue will be keeping backwards-compat for some duration (presumably until 1.0.0). In the event there is a breaking change to some plugin implementation (i.e. I define a |
I guess this would be a task rigth before 1.0.0, but just to get it out. On the flipside, already a pain in the ass to change now, it doesn't get better with time.
in a multiplatform framework we shouldn't goup the plugins containing the platforms' name
ovos-plugin-manager/ovos_plugin_manager/utils/__init__.py
Lines 23 to 44 in 68ec25f
The text was updated successfully, but these errors were encountered: