Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make failed due to no m4 , it should be included in the "script/install_dependency.sh" #159

Open
meiyanz opened this issue Jun 10, 2020 · 2 comments

Comments

@meiyanz
Copy link
Contributor

meiyanz commented Jun 10, 2020

Issue Description:
compile failure "make " on the pure machine of the latest version.
Error log:
Scanning dependencies of target build_docker_swarm
../../../deployment/docker-swarm/build.sh: line 10: m4: command not found
deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/build.make:57: recipe for target 'deployment/docker-swarm/CMakeFiles/build_docker_swarm' failed
make[2]: *** [deployment/docker-swarm/CMakeFiles/build_docker_swarm] Error 127
CMakeFiles/Makefile2:198: recipe for target 'deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/all' failed
make[1]: *** [deployment/docker-swarm/CMakeFiles/build_docker_swarm.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
Reproduce Rate: 100%.
Command : make
The commit information: commit 2c591a8
Reproduce:
$ git clone https://github.com/OpenVisualCloud/CDN-Transcode-Sample.git
$ cd CDN-Transcode-Sample
$ sudo -E ./script/install_dependency.sh
$ sudo mkdir -p /etc/systemd/system/docker.service.d
$ printf "[Service]\nEnvironment="HTTPS_PROXY=$https_proxy" "NO_PROXY=$no_proxy"\n" | sudo tee /etc/systemd/system/docker.service.d/proxy.conf
$ sudo systemctl daemon-reload
$ sudo systemctl restart docker
$ mkdir build && cd build
$ cmake ../ -DNVODS=1 -DNLIVES=0
$ make

@xwu2git
Copy link
Contributor

xwu2git commented Jun 10, 2020

Is it a difficult system? m4 is needed for both docker swarm and Kubernetes build.
yes, m4 is needed. The minimum dependencies are: cmake, m4, awk, sed, grep, cut, and then a fully functional docker, and one of docker (swarm), kubectl, or helm.

BTW, the script install_dependency.sh actually installs too many non-essential dependencies. I would not recommend to run it as a build step. @TangZhiZhen, could you clean it up?

@xwu2git
Copy link
Contributor

xwu2git commented Jun 10, 2020

For example, docker-ce should not be installed in install_depedency.sh. The docker choice should be left to the user, which may prefer to use docker-ee instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants