Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch and tree to About route #636

Merged
merged 2 commits into from
May 30, 2015
Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented May 29, 2015

  • Continue to use parallel async to retrieve info via git abstract
  • New dep of git-rev to abstract a little... direct exec is also available
  • Bump node engine to latest 0.12.4

Closes #426 and post dependency of #635 after merge.


NOTES:

  • exec is still compatible with node 0.10.x whereas I could have used execSync in node 0.12.x... however it appears faster to keep it parallel asynchronous using async with exec
  • This should also eliminate the administrative task/need to push releases here on GH to cut down some noise and questions of "Are we there yet? Are we there yet? Are we there Yet?" * Simpsons e.g. are we in sync between GH dev and host production for issue creation/understanding.

* Continue to use parallel *async* to retrieve info via git abstract
* New dep of *git-rev* to abstract a little direct `exec` is also available
* Bump *node* engine to latest 0.12.4

Closes OpenUserJS#426 and post dependency of OpenUserJS#635 after merge.
@Martii Martii added UI Pertains inclusively to the User Interface. migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels May 29, 2015
* Remove *jitsu* reference as soon to be obsolete with OpenUserJS#635

Applies to OpenUserJS#636 and OpenUserJS#426
@Martii Martii added the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label May 29, 2015
Martii added a commit that referenced this pull request May 30, 2015
Add branch and tree to About route

Auto-merge
@Martii Martii merged commit fc36084 into OpenUserJS:master May 30, 2015
@Martii Martii deleted the Issue-426 branch May 30, 2015 06:59
@Martii Martii removed the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label May 30, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

Create a dummy key in ./package.json or other .json for commit hash for deployment access
1 participant