Fix validation of modified declarations #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the method for identifying modified service term types by addressing issues with new service additions and modified filters.
Ndpnt
force-pushed
the
fix-modified-declarations-validations
branch
from
9e86530 to
ac0196a
Compare
clementbiron
approved these changes
Apr 5, 2024
MattiSG
reviewed
Apr 8, 2024
| "select": "body" | ||
| }, | ||
| "Privacy Policy": { | ||
| "fetch": "https://domain.example/tos", |
There was a problem hiding this comment.
Suggested change
| "fetch": "https://domain.example/tos", | |
| "fetch": "https://domain.example/privacy", |
scripts/declarations/utils/index.js
Outdated
|
|
||
| return JSON.parse(fileContent); | ||
| } catch (error) { | ||
| return undefined; |
There was a problem hiding this comment.
Suggested change
| return undefined; | |
| return; |
| const servicesTermsTypes = {}; | ||
|
|
||
| await Promise.all(modifiedFilePaths.map(async modifiedFilePath => { | ||
| const serviceId = DeclarationUtils.filePathToServiceId(modifiedFilePath); | ||
| const serviceId = DeclarationUtils.getServiceIdFromFilePath(modifiedFilePath); |
There was a problem hiding this comment.
Extract the block in map to new function, it is too long to be declared this way in an iteration 🙂
There was a problem hiding this comment.
I do not understand what you mean here
There was a problem hiding this comment.
The whole anonymous function that is defined and called as the map parameter is huge. I believe it would help with readability if it was extracted into its own named function.
There was a problem hiding this comment.
With the code simplification, I no longer find it useful.
scripts/declarations/utils/index.js
Outdated
| const declaration = await this.getJSONFile(`declarations/${serviceId}.json`, this.defaultBranch); | ||
| // TODO: Implement AST comparison between original and modified "filters" files to detect changes in functions, enabling identification of terms whose types depend on modified functions. | ||
| // Due to the complexity involved, temporarily returning all term types. | ||
| servicesTermsTypes[serviceId] = Object.keys(declaration.documents); |
There was a problem hiding this comment.
Since we
map, why use an outside variable instead of using the return value ofmap?
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the method used to identify modified services term types. It address two key issues:
Others improvements:
deep-diffdependency