Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata and improve doc #1064

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Update metadata and improve doc #1064

merged 5 commits into from
Mar 20, 2024

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Mar 18, 2024

No description provided.

@Ndpnt Ndpnt requested a review from MattiSG March 18, 2024 14:15
MattiSG
MattiSG requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked other metadata: the homepage should be updated as well. Did you try regenerating the package-lock.json? 🙂

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Ndpnt
Copy link
Member Author

Ndpnt commented Mar 18, 2024

Did you try regenerating the package-lock.json? 🙂

There is no changes

MattiSG
MattiSG requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo.

CONTRIBUTING.md Outdated Show resolved Hide resolved
MattiSG
MattiSG approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!!

@Ndpnt Ndpnt force-pushed the update-metadata branch from 7b2778b to c69759e Compare March 20, 2024 08:37
@Ndpnt Ndpnt merged commit 4935770 into main Mar 20, 2024
9 checks passed
@Ndpnt Ndpnt deleted the update-metadata branch March 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndpnt @MattiSG