Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NodeJS to version 20 #1024

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Upgrade NodeJS to version 20 #1024

merged 4 commits into from
Oct 6, 2023

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Oct 6, 2023

  • Upgrade GitHub actions
  • Upgrade dependencies

Tested locally with NodeJS 20 and NPM 10 after removing and reinstalling all the dependencies and everything works.

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package lock should not be updated in relation to the GitHub Actions.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Ndpnt Ndpnt changed the title Upgrade GitHub actions NodeJS to version 20 Upgrade NodeJS to version 20 Oct 6, 2023
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If tests pass, everything should be fine 🙂

@MattiSG MattiSG enabled auto-merge October 6, 2023 14:47
@MattiSG MattiSG merged commit c0d388b into main Oct 6, 2023
7 checks passed
@MattiSG MattiSG deleted the update-to-node-20 branch October 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants