Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Bug in LS/RS slider when pins are defined as -1 during compile #41

Closed
TheTrainGoes opened this issue Aug 13, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@TheTrainGoes
Copy link

There is currently a bug where if the LS / RS slider is defined as -1 in the config file the unit will default to LS.

Stick selection is not persistent though reset so it will always go back to LS even if placed in a different mode via the online config.

There are two ways that I believe we can address this:

1 - Make DPad mode the default, not LS
2 - Force defining of a pin for each the LS / RS slider pins

Additionally, Ferals old documentation talks about a shortcut for selecting the functions via start + select + left for LS, right for RS and up for DPad, I would like to explore having this added as there is no way to do this currently while in game.

@TheTrainGoes TheTrainGoes added the bug Something isn't working label Aug 13, 2022
@arntsonl
Copy link

Pins for LS and RS were set to unsigned 8-bit, which cause the comparisons to fail. Added cast on the conversions, will note for future issues.

@arntsonl arntsonl self-assigned this Aug 14, 2022
@arntsonl
Copy link

Fixed in 0.5.1 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants