fix: Scopes order in dropdown #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentinchampenois
requested review from
moustachu,
luciegrau,
a team and
AyakorK
and removed request for
a team
moustachu
approved these changes
Nov 7, 2023
luciegrau
approved these changes
Nov 7, 2023
luciegrau
added a commit
that referenced
this pull request
Nov 8, 2023
#45) * add simple proposals * Add simple proposal and decidim awesome's correct branch The simple proposal module is on my personal fork because modifications to the position of the field were necessary. The decidim awesome one is on an octree fork because the private proposals feature is yet to be merge into the main decidim awesome repo * fix Gemfile for decidim-simple_proposal overload * Rubocop & ERB Lint * Add missing migration * rubocop * Fix proposal creation for SimpleProposal x Awesome proposal private fields - remove old proposals_controller.rb overload - overload SimpleProposals proposals_controller_override.rb * Fix i18n locales * Fix tests i18n * rubocop * fix: Remove exports from Phone AH * fix: Deactivate factory_bot * lint: Fix rubocop offense * fix: reversibility private body * fix: Move address field in edit form * fix: Add missing simple proposal translation * fix: Scopes order in dropdown (#44) * fix: Scopes order in dropdown * fix: Ensure scopes are only those in current_organization --------- Co-authored-by: Simonas <[email protected]> Co-authored-by: quentinchampenois <[email protected]> Co-authored-by: Lucie Grau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Description
Please describe your pull request.
With the simple proposal module, scopes are not anymore multi-tenant compliant. This PR ensure scopes retrieved are related to current_organization.
It also sorts the scopes and subscopes by alphabetical order
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
Example:
Tasks