Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NetPyNE branch in jupyterlab docker to use 'osbv2-dev' #580

Closed
sanjayankur31 opened this issue Sep 12, 2022 · 7 comments
Closed

Update NetPyNE branch in jupyterlab docker to use 'osbv2-dev' #580

sanjayankur31 opened this issue Sep 12, 2022 · 7 comments
Assignees

Comments

@sanjayankur31
Copy link
Collaborator

It needs to be:

https://github.com/OpenSourceBrain/OSBv2/blob/develop/applications/netpyne/Dockerfile#L26

Currently it's "osbv2" in requirements.txt:

https://github.com/OpenSourceBrain/OSBv2/blob/develop/applications/jupyterlab/requirements.txt#L9

@filippomc
Copy link
Contributor

since we are releasing wouldn't it be better to update the osbv2 branch? I think we should do the same on netpyne-ui

@filippomc
Copy link
Contributor

@sanjayankur31 thoughts?

@sanjayankur31
Copy link
Collaborator Author

Sorry, missed the notification---I don't think we care about what particular branch it is as long as it's the latest netpyne/netpyne ui branche that we need on v2.

@filippomc
Copy link
Contributor

not sure what action to take still. Should we release with osbv2-dev branch or are you updating the osbv2 branch to have the latest?

@sanjayankur31
Copy link
Collaborator Author

We'll need to wait till Padraig returns from leave for this one.

@filippomc
Copy link
Contributor

@pgleeson thoughts?

@pgleeson
Copy link
Member

@filippomc The https://github.com/suny-downstate-medical-center/netpyne/tree/osbv2 branch now has all the latest changes from the netpyne core dev branch and should be used in both the jupyterlab and netpyne-ui dockerfiles. The version will show up as 1.0.3.1_osbv2

@SimaoBolota-MetaCell SimaoBolota-MetaCell changed the title Update NetPyNE branch in jupyterlab docker to use "osbv2-dev" Update NetPyNE branch in jupyterlab docker to use 'osbv2-dev' Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants