-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NetPyNE branch in jupyterlab docker to use 'osbv2-dev' #580
Comments
since we are releasing wouldn't it be better to update the osbv2 branch? I think we should do the same on netpyne-ui |
@sanjayankur31 thoughts? |
Sorry, missed the notification---I don't think we care about what particular branch it is as long as it's the latest netpyne/netpyne ui branche that we need on v2. |
not sure what action to take still. Should we release with osbv2-dev branch or are you updating the osbv2 branch to have the latest? |
We'll need to wait till Padraig returns from leave for this one. |
@pgleeson thoughts? |
@filippomc The https://github.com/suny-downstate-medical-center/netpyne/tree/osbv2 branch now has all the latest changes from the netpyne core dev branch and should be used in both the jupyterlab and netpyne-ui dockerfiles. The version will show up as |
It needs to be:
https://github.com/OpenSourceBrain/OSBv2/blob/develop/applications/netpyne/Dockerfile#L26
Currently it's "osbv2" in requirements.txt:
https://github.com/OpenSourceBrain/OSBv2/blob/develop/applications/jupyterlab/requirements.txt#L9
The text was updated successfully, but these errors were encountered: