Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOCA - state management for marketplace and appliance #6311

Closed
3 tasks done
treywelsh opened this issue Sep 7, 2023 · 0 comments
Closed
3 tasks done

GOCA - state management for marketplace and appliance #6311

treywelsh opened this issue Sep 7, 2023 · 0 comments

Comments

@treywelsh
Copy link
Contributor

treywelsh commented Sep 7, 2023

Description

Marketplace and marketplace appliance have a state each, in Goca marketplace state are not manage at all, and marketplace appliance structure has a State field.
I'll propose a PR that try to add state management for both and I'll try to be consistent with state management API already implemented for other resources (hosts etc.)

Use case
I'll use this in the terraform provider

Interface Changes
This could be implement without breaking change but to maximize API consistency acrosse resources I'll probably rename a structure field, which is a breaking change but doesn't seems a big deal to me

Additional Context
Please feel free to add any other context or screenshots about the feature request here. Or any other alternative you have considered to address this new feature.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 7, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 8, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 8, 2023
treywelsh added a commit to treywelsh/one that referenced this issue Sep 8, 2023
paczerny added a commit to treywelsh/one that referenced this issue Sep 11, 2023
rsmontero pushed a commit that referenced this issue Sep 12, 2023
- Add state to Markeplace
- Add state Markeplace Appliance
- Add enable method for Marketplace
- Add tests and use gocheck

co-authored-by: Pavel Czerny <[email protected]>

Signed-off-by: Pierre Lafievre <[email protected]>
rsmontero added a commit to OpenNebula/docs that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants