Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests with required unified shared should not FAIL if unified shared memory is not supported #494

Open
spophale opened this issue Mar 15, 2022 · 1 comment
Open

Tests with required unified shared should not FAIL if unified shared memory is not supported #494

spophale opened this issue Mar 15, 2022 · 1 comment
Assignees
@tmh97 @nolanbaker31
Labels
enhancement New feature or request

Comments

@spophale
Copy link
Collaborator

spophale commented Mar 15, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Observation was made by AMD that the test that require unified shared memory FAIL even if unified shared memory is not available.

Describe the solution you'd like
If unified shared memory is not detected than the tests should not report FAIL.

Describe alternatives you've considered
Either PASS (but that would give the incorrect impression), or should exit with a meaningful message. IMO "SKIPPED" would be a good status to report.
@spophale spophale added the enhancement New feature or request label Mar 15, 2022
@nolanbaker31
Copy link
Contributor

nolanbaker31 commented Jan 22, 2023 •
edited
Loading

Do we currently have the infrastructure to report "skipped"? Should it pass with that message, or implement a skipped option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmh97 tmh97

@nolanbaker31 nolanbaker31

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spophale @tmh97 @nolanbaker31