Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVT:Adding feature to server.xml to the end of the feature sequence sometimes removes some chars #405

Open
rumanaHaque opened this issue Jun 19, 2023 · 4 comments
Labels
bug Something isn't working with the product SVT Opened by SVT team
Milestone

Comments

@rumanaHaque
Copy link

rumanaHaque commented Jun 19, 2023

While testing using ACME ee10 app - for TER https://github.ibm.com/websphere/system-test/issues/765
ran into this issues when adding features to the server.xml

When I click on <fe Ctrl+space, feature completion makes it

When I do app Ctrl+space, it shows diff options, including appAuthentication-2.0
When I select that feature, it adds it, but also removes the </ from the front of the feature.
Here's a screenshot.

image

@rumanaHaque rumanaHaque added bug Something isn't working with the product SVT Opened by SVT team labels Jun 19, 2023
@cherylking
Copy link
Member

Is this the same as #470 ?

@scottkurz scottkurz added this to the 24.0.3 milestone Nov 10, 2023
@scottkurz scottkurz changed the title SVT:Adding feature to server.xml sometimes removes some chars SVT:Adding feature to server.xml to the end of the feature sequence sometimes removes some chars Jan 31, 2024
@scottkurz
Copy link
Member

Just noticing that in the screenshot and in my recreates in #470, the feature which this happened to was always the last one in the list, the one right before the </featureManager> end tag.

I have a vague sense that the Lemminx self-closing feature is somehow wrongly getting activated here. E.g. see the video recording here: eclipse-lemminx/lemminx#354 . Not sure it really helps all that much to note this even, but it's something I guess.

I don't think Lemminx has enough logging to turn on trace... e.g. if I look at
https://github.com/eclipse/lemminx/blob/main/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/XMLFormatterDocument.java which vaguely seems it might be relevant, it only seems to log maybe big error conditions.

I suppose enabling JDK trace like OpenJ9 Xtrace could be an option ... possibly for that class or the org.eclipse.lemminx.services.format.* package. Probably this is only worth doing if we can first know that we can recreate this consistently though.

@scottkurz
Copy link
Member

Noticing too there is an extra closing bracket char '>' before the last feature. I wonder if that's relevant. I know, in the dup #470 issue it isn't there in the screenshot.. but perhaps that was removed before the screenshot was taken? IDK, maybe some fast typing and slow response gets the editor in some inconsistent syntax state, leading to this issue.

@scottkurz scottkurz modified the milestones: 24.0.3, 24.0.6 Feb 1, 2024
@rumanaHaque
Copy link
Author

Just recreated this defect again today, using LTE version - 23.0.12.202311151445.
I don't have the '>' while doing the recreate, as seen in this screenshot.

image

@scottkurz scottkurz modified the milestones: 24.0.6, 24.0.9 Apr 26, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.9, 24.0.12 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working with the product SVT Opened by SVT team
Projects
None yet
Development

No branches or pull requests

4 participants