Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Spring Boot 3.0 once Open Liberty supports it #1703

Closed
cherylking opened this issue Jun 27, 2023 · 9 comments · Fixed by #1742
Closed

Add support for Spring Boot 3.0 once Open Liberty supports it #1703

cherylking opened this issue Jun 27, 2023 · 9 comments · Fixed by #1742

Comments

@cherylking
Copy link
Member

Open Liberty is adding support for Spring Boot 3.0 with this epic. Some plugin code will need to be modified in order to support it, and a new test case should be added. Similar updates will be needed in Liberty Gradle Plugin as well.

@cherylking
Copy link
Member Author

Looks like Open Liberty 23.0.0.9 will include Spring Boot 3.0 and has an eGA of 9/19.

@cherylking
Copy link
Member Author

@hlhoots @cbridgha Is someone from your team looking at the changes needed in the Liberty Maven and Gradle plugins for support of Spring Boot 3.0? The original support was added by Anjum Fatima. I am somewhat familiar with the code, but would need definite pointers on the changes needed.

@cbridgha
Copy link
Member

Its not clear anything specific to SB 3 needs to happen - @cherylking Can you find the original PR from @anjumfatima90 ? Maybe at most you guys need to add a testcase?

@cherylking
Copy link
Member Author

Its not clear anything specific to SB 3 needs to happen - @cherylking Can you find the original PR from @anjumfatima90 ? Maybe at most you guys need to add a testcase?

I know changes are needed, as there is logic specific to 1.x vs 2.x. I will find the original PR and link it.

@cherylking
Copy link
Member Author

Here are a couple of examples in ci.gradle that would need modifying. I would expect something similar in ci.maven, but have not tracked it down yet. I cannot link the original PRs because that code was added before we migrated our repos to OpenLiberty in public Github.

https://github.com/OpenLiberty/ci.gradle/blob/main/src/main/groovy/io/openliberty/tools/gradle/tasks/DeployTask.groovy#L168

https://github.com/OpenLiberty/ci.gradle/blob/main/src/main/groovy/io/openliberty/tools/gradle/tasks/DeployTask.groovy#L226

I don't know if there are any fundamental differences that need to be accounted for between 2.x and 3.x.

@cherylking
Copy link
Member Author

Open issue in ci.gradle related to SB 3.0 support.

@cherylking cherylking self-assigned this Sep 15, 2023
@cherylking
Copy link
Member Author

There are 4 classes and 6 different methods that check for version 1.x versus 2.x in the ci.gradle code. I found none in ci.maven code.

@cherylking
Copy link
Member Author

cherylking commented Sep 21, 2023

While adding a test case for SpringBoot 3.0, I ran into a NoClassDefFoundError when our plugin code calls the springBootUtility. That problem is being tracked in this OL issue.

@github-project-automation github-project-automation bot moved this from Target feature release to ✅ Done in Liberty Tools Release Plan Oct 20, 2023
@cherylking
Copy link
Member Author

Issue for blog post: OpenLiberty/open-liberty#27087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants