Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-module support for dev mode with Gradle #625

Open
dgeissl opened this issue Sep 6, 2021 · 1 comment
Open

Multi-module support for dev mode with Gradle #625

dgeissl opened this issue Sep 6, 2021 · 1 comment

Comments

@dgeissl
Copy link

dgeissl commented Sep 6, 2021

The libertyDev task adds some file monitoring but only for the current project (also see #624 ).

However as soon as the current project does not contain all sources but has dependencies to other projects even if they are in the same multiproject build - their source folders are not included making the feature unpredictable or even useless.

For my test case I am using a ear to deploy the application (which has no java sources at all) and all ejbs and web applications are in dependent projects

plugins { id 'ear' }
dependencies {
    deploy project(':my_ejb_project')
    deploy project(':my_web_project')
    earlib project(':my_commons')
}

In this configuration - file system watching is completely useless as is.

The file system monitoring should include all output folders from all project dependencies. The DeployTask already collects the nessesary folders for the LooseEarApplication:

private void processDeployDependencies(LooseEarApplication looseEar, Task task) {

In case the project is very big (thinking of legacy projects) - a closure to filter the monitored projects may also be a good idea.

@dgeissl
Copy link
Author

dgeissl commented Sep 7, 2021

Seems to be very much the same issue as with the ci.maven plugin OpenLiberty/ci.maven#697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Developer Experience
Development

No branches or pull requests

2 participants