Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line property -Pliberty.runtime.version does not override default OL runtime version #607

Closed
mezarin opened this issue Jun 14, 2021 · 1 comment · Fixed by #608
Closed
Labels

Comments

@mezarin
Copy link
Member

mezarin commented Jun 14, 2021

When I run this command that defines the -Pliberty.runtime.version property (For example: gradle libertyDev -Pliberty.runtime.version=21.0.0.3), the Liberty version installed is the latest one and not the version specified.
This happens whether or not I specify the libertyRuntime dependency in build.gradle.

According to this documentation: https://github.com/OpenLiberty/ci.gradle/blob/main/docs/installLiberty.md, and the example command above, OL version 21.0.0.3 should have been resolved/installed.

I can workaround this by having a gradle.properties file with the above property specified, or I can define/override the liberty version directly in build.gradle (i.e. under dependencies or liberty.runtime).

@cherylking
Copy link
Member

@ericglau The InstallLibertyTask looks for the liberty.runtime project properties in buildInstallLibertyMap(). Does the DevTask need to do something to pass those along to the BuildLauncher that calls libertyCreate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants