Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filter in iD should prefer EDTF dates over basic dates #671

Open
1ec5 opened this issue Jan 7, 2024 · 0 comments
Open

Date filter in iD should prefer EDTF dates over basic dates #671

1ec5 opened this issue Jan 7, 2024 · 0 comments
Labels

Comments

@1ec5
Copy link
Member

1ec5 commented Jan 7, 2024

Now that OpenHistoricalMap/iD#187 has added an EDTF date field and validator, the user might expect the date filter to filter features based on the EDTF dates when available. This would make it easier to edit in areas without many certain dates.

The edtf.js library we’re using can return the minimum and maximum possible dates of an EDTF date, optionally with the same precision as the input.

This filtering would be inconsistent with the renderer until we implement similar EDTF-based filtering in the tile generator: #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant