ID Warnings and Errors

[natfoot]

Bug description
ID validator counties to throw out warnings and errors that are not relevant to the OHM project.
This includes
roads that are only connected together as we don't have as much data and is not necessarily in need of a warning.
roads and way overlapping and not connecting as they may be from different time periods

What should be happening?
Warnings that are more consistent with the OHM project.

Repro Steps
Please provide detailed instructions to reproduce the behavior:

1. ID Editor
2. Overlap any set of roads and either connect a few or not.
3. then save
4. see list below in left panel for warnings and errors before change set description save

Screenshots & URL
Where this is found in ID see GitHub
iD/modules/validations

[natfoot]

If we can just tell ID not to have these it may be better than leaving them active.

[Dimitar5555]

It seems like certain validators can be disabled using https://github.com/openstreetmap/iD/blob/053b652548863bce8344b043d0d30973cf40bb9a/modules/core/validator.js#L16

[1ec5]

roads and way overlapping and not connecting as they may be from different time periods

The crossing ways validator rule already makes some exceptions for features that are on different layers, different levels, etc. We should add an exception for when the two ways’ date ranges don’t overlap. This requires doing string comparisons on the start_date and end_date tags of the two features.

If one feature begins on the same day that another feature ends, we should let them overlap, because we don’t yet have support for more precise time tagging. The comparison would be a bit more complex once we add support for EDTF: #15 #304.

[1ec5]

roads and way overlapping and not connecting as they may be from different time periods

The crossing ways validator rule already makes some exceptions for features that are on different layers, different levels, etc. We should add an exception for when the two ways’ date ranges don’t overlap. This requires doing string comparisons on the start_date and end_date tags of the two features.

I added this exception in OpenHistoricalMap/iD#137.

[1ec5]

OpenHistoricalMap/iD#137 landed in the new staging branch we’re working on for #395. I ended up adding an exception to three different validator rules, so I think this issue is now resolved. GitHub hasn’t closed it automatically because staging-old is still this repository’s default branch; it’s waiting for us to merge staging into staging-old, which will never happen.

[1ec5]

Fixed in OpenHistoricalMap/iD#137.