Adopt code from py2neo to remove the use of the id function in cypher queries
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code included from py2neo is under the apache 2.0 license and therefore we need to include a copy of apache 2.0 along with a NOTICE with information on our changes to the code.
|
Closes #291. |
ianmkenney
changed the title
id function in cypher queries
ianmkenney
changed the title
id function in cypher queriesid function in cypher queries
Our documentation is numpy style. The adopted docstrings have been modified to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unmaintained
py2neopackage generated queries contain functions that are deprecated. In order to avoid the a torrent of deprecation warnings in the near future and broken functionality on the next major release of neo4j, we are adopting the query generators from within py2neo and modifying them to satisfy our needs in alchemiscale.In compliance with the Apache v2.0 license, we are providing a copy of the Apache v2.0 license with our distribution and providing a NOTICE containing a log of our modifications.