-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate OutListParameters.xlsx Into OpenFAST #413
Comments
Like @andrew-platt mentioned in #391 (comment), the spreadsheet does exist in some form in the openfast-library src. A few others are located in the module directories:
I'm not sure why there are two versions of some of these. In any case, if there's no functional reason for that, I suggest that they be consolidated into the "main" one in openfast-library. |
Thanks @rafmudaf for clarifying! I misread @andrew-platt's comment. Regardless, the OutListParameters.xlsx spreadsheet must still be updated/corrected. For modularization sake, I would suggest having a separate OutListParameters.xlsx spreadsheet for each module that needs one. This is already the case for several modules, but I would suggest doing the same for ElastoDyn, ServoDyn, etc. |
I had a chat with @andrew-platt about the |
How about appending the module name to each spreadsheet, e.g., OutListParameters_ElastoDyn.xlsx? |
That's better than all with the same name. However, I still prefer to have one spreadsheet with a tab for each module, and then put it in a documentation directory. It makes it easier to compare variable names against those in different modules. |
Good point - this should be moved to |
If we move it to If we didn't keep all the documentation in one place but rather split it out into each modules source directory, then I would lean towards splitting the |
Updated in #429 |
As mentioned in #391, the OutListParameters.xlsx spreadsheet for ElastoDyn, ServoDyn, etc. have not yet been migrated from FAST v8.16 to OpenFAST. This spreadsheet contains a list of all possible output parameters from ElastoDyn, ServoDyn, etc., including their name(s), description, coordinate system, and units. Not only is this spreadsheet useful documentation, but it is also used to auto-generate output-processing source code, and so, is important to keep updated when changing the source code. This spreadsheet should be migrated to OpenFAST.
Also, as mentioned in the following topic on our forum: https://wind.nrel.gov/forum/wind/viewtopic.php?f=4&t=2458&p=14236, the local tower forces from ElastoDyn--TwrHt1FLxt, TwrHt1FLyt, and TwrHt1Flzt etc.--are not described correctly in the OutListParameters.xlsx spreadsheet. They should be described as "Local tower fore-aft shear force of tower gage 1", "Local tower side-to-side shear force of tower gage 1", and "Local tower axial force of tower gage 1" etc., respectively. This description should be fixed.
The text was updated successfully, but these errors were encountered: