Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oeo-tools as submodule and build imports in the CI #1888

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

areleu
Copy link
Contributor

@areleu areleu commented Jul 10, 2024

Summary of the discussion

Discussed in https://etherpad.wikimedia.org/p/oeo-dev-82

Type of change (CHANGELOG.md)

Update

  • Updated import build system

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@areleu areleu marked this pull request as draft July 10, 2024 08:24
@areleu
Copy link
Contributor Author

areleu commented Jul 11, 2024

The changes in the imported modules are according to the current scripts if there is something that is not desireable let me know so I can take a look specifically. I suspect the differences come from the fact that we don't fix the version of the imported ontology.

@areleu
Copy link
Contributor Author

areleu commented Jul 11, 2024

I would wait until merging: OpenEnergyPlatform/oeo-tools#18 before merging this, so long I will keep it as a draft.

@areleu
Copy link
Contributor Author

areleu commented Oct 9, 2024

oeo-tools has to be rebased in this PR, the contents of the imports in the latest version should be added too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

1 participant