Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit needs a new definition #533

Closed
5 tasks done
sfluegel05 opened this issue Aug 26, 2020 · 6 comments · Fixed by #537
Closed
5 tasks done

unit needs a new definition #533

sfluegel05 opened this issue Aug 26, 2020 · 6 comments · Fixed by #537
Assignees
Labels
[C] definition update Update an ontology definition economic terms

Comments

@sfluegel05
Copy link
Contributor

Description of the issue

The current definition of unit is A unit of measurement is a standardized quantity of a physical quality.
This doesn't work for currencies which are units as well (as discussed in oeo developer meeting 8.2).
Currencies are needed for prices, see #331.
Therefore we need a new definition that includes currencies.

Ideas of solution

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@akleinau
Copy link
Contributor

We just have to delete the "physical quality" part, right? That was the problem why money didn't work with it

@l-emele
Copy link
Contributor

l-emele commented Aug 27, 2020

I wasn't part of the discussion, but isn't it enough to delete the word physical as it is still related to a quality?

@jannahastings
Copy link
Contributor

Alternatively, we could try A standardised quantity of a quantifiable entity ?

@stap-m
Copy link
Contributor

stap-m commented Aug 27, 2020

unit is imported btw. Is it ok to change it?

@jannahastings
Copy link
Contributor

unit is imported btw. Is it ok to change it?

Yes, I think it is fine as long as we add a comment giving an explanation.

@stap-m
Copy link
Contributor

stap-m commented Aug 27, 2020

Nice. Ready for implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] definition update Update an ontology definition economic terms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants