Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another study descriptor to the bundles #1489

Closed
1 task
stap-m opened this issue Dec 5, 2023 · 6 comments · Fixed by #1491 or #1717
Closed
1 task

Add another study descriptor to the bundles #1489

stap-m opened this issue Dec 5, 2023 · 6 comments · Fixed by #1491 or #1717
Assignees
Labels
enhancement Scenario Bundle Feature of the oeplatform. Time-S Low estimated time to work off, voted on in project meeting Urgency-L urgency level: large

Comments

@stap-m
Copy link
Contributor

stap-m commented Dec 5, 2023

Description of the issue

This comes from
OpenEnergyPlatform/ontology#1777

With the new OEO release 2.1.0 there will be a new class study report due to leggal obligation added, which should be available in the scenario bundles to be selected as study descriptor.

grafik

Workflow checklist

@stap-m
Copy link
Contributor Author

stap-m commented Dec 18, 2023

I thought that the study descriptors were already linked to oeo terminology, but it seems that this is not the case. The list of descriptors, that should show, can be found in the table in this issue, already with the correct IRI: OpenEnergyPlatform/oekg#19.
Only few terms are still missing.
I'd like to review the PR when you've implemened, for the fine tuning, if this is possible.

@stap-m stap-m reopened this Dec 18, 2023
@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 18, 2023

That's a good idea to participate in the PR review for fine tuning!

Since we had a lot of problems last week trying to do the major Pyhon version update on our servers, the new OEP release is not yet available. But on the TOEP there is the updated version of the Scenario Bundles with update for the descriptors, which I also thought was linked to the oeo terms already.

So this is how it is currently when you edit the descriptors (linked via tooltip box):

image

and like this when you look at a bundle. Grayed out badges indicate that there is no link / no oeo term (linked via click on descriptors badge):
image

Looking at the list you provided, this doesn't seem to work properly, as descriptors like "greenhouse gas emissions" are grayed out. @adelmemariani, do you know the reason for this?

@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 18, 2023

I have opened another issue as the missing links seem to be a bug.
@adelmemariani

--> #1507

@stap-m
Copy link
Contributor Author

stap-m commented Apr 18, 2024

There are still descriptors missing in the scenario bundles that should be selectable. The required list can be found here: OpenEnergyPlatform/oekg#19
Almost all descriptors are now available in the OEO.

@jh-RLI
Copy link
Contributor

jh-RLI commented Jun 13, 2024

The list of descriptors was updated in PR #1717

@jh-RLI jh-RLI closed this as completed Jun 13, 2024
@jh-RLI
Copy link
Contributor

jh-RLI commented Jun 13, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Scenario Bundle Feature of the oeplatform. Time-S Low estimated time to work off, voted on in project meeting Urgency-L urgency level: large
Projects
3 participants