Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy oeo imports #4

Merged
merged 18 commits into from
Dec 1, 2023
Merged

tidy oeo imports #4

merged 18 commits into from
Dec 1, 2023

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Nov 1, 2023

ToDos here

  • comment on txt files with import declarations: iao, omo
  • include may be identical to to iao import

ToDo in oeo repo

  • add new iao-extracted.owl from this repo
  • remove omo import
  • oeo-import-edits: --> see see update iao import #1700 ontology#1754
    • domain of is about
    • parent class of information content entity

Next steps

  • add aditional classes to iao imports

@stap-m
Copy link
Contributor Author

stap-m commented Nov 1, 2023

Seems like all annotation properties and entities we import from omo, apart from may be identical to, are also imported from iao (implicitly or explicitly), hence we have them twice.
may be identical to can also be imported from iao, instead, which would make the omo import obsolete.

Copy link
Contributor Author

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove local paths

oeo-imports/iao/extract-iao-module.sh Outdated Show resolved Hide resolved
oeo-imports/iao/extract-iao-module.sh Outdated Show resolved Hide resolved
oeo-imports/iao/extract-iao-module.sh Outdated Show resolved Hide resolved
oeo-imports/iao/extract-iao-module.sh Outdated Show resolved Hide resolved
@stap-m stap-m self-assigned this Nov 1, 2023
@stap-m
Copy link
Contributor Author

stap-m commented Nov 13, 2023

@h-spinde the new iao-extracted looks fine for me.
As a next step, please copy it to the oeo repo and perform the following steps in a new PR. Let me know, if you have questions.

ToDo in oeo repo

  • add new iao-extracted.owl from this repo
  • remove omo import
  • oeo-import-edits:
    • domain of is about
    • parent class of information content entity

EDIT: see OpenEnergyPlatform/ontology#1754

@stap-m
Copy link
Contributor Author

stap-m commented Nov 22, 2023

@h-spinde please run the scipt again based on the newest version of iao-w-hierarchy.sh in this PR and push the result here. Please let me know once its done.
Does ist cause problems that there is an OBI class involved which IAO seems to import?

@h-spinde
Copy link
Contributor

I have run the new script and uploaded it. There shouldn't be any problems caused by the imported OBI class, especially since it isn't actually used anywhere. Though I am admittedly confused by how it is getting imported in the first place, since it's neither in iao-w-hierarchy.txt, nor relevant to any other class being imported.

@stap-m
Copy link
Contributor Author

stap-m commented Nov 27, 2023

The OBI class was requested newly and wasn't imported before.

@stap-m
Copy link
Contributor Author

stap-m commented Nov 28, 2023

@h-spinde can you run the script with the updated iao-w-hierarchy on short notice, i.e. today or tomottow?

EDIT: I managed if myself now.

@stap-m stap-m requested review from h-spinde and l-emele November 29, 2023 11:25
@stap-m stap-m requested a review from areleu December 1, 2023 08:15
@areleu
Copy link
Contributor

areleu commented Dec 1, 2023

Tried doing the axiom cleanup using robot merge -i iao-extracted.owl repair --merge-axiom-annotations true -o iao-extracted.owl from: ontodev/robot#1099 (comment)
But it breaks the ontology so we may need other solution, since this import is reproducible I think this is good to merge

Copy link
Contributor

@areleu areleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest comment

@stap-m stap-m merged commit 8b231a9 into main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants