Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata quility badge-system #117

Merged
merged 31 commits into from
Apr 12, 2023
Merged

Add metadata quility badge-system #117

merged 31 commits into from
Apr 12, 2023

Conversation

christian-rli
Copy link
Contributor

This (re)implements the changes worked out by @steull . It's a reproduction of the changes referenced in #113 . Unfortunately, it was built on an outdated branch.

Closes #112

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Please add a changelog entry.

Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typo's and inconsistencies.
Also added some remarks.

Feel free to accept at least the obvious improvements.

metadata/latest/schema.json Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
metadata/latest/schema.json Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
metadata/latest/schema.json Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
metadata/latest/schema.json Outdated Show resolved Hide resolved
Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the proposed changes!

@christian-rli
Copy link
Contributor Author

Thank you for finding all the redundancies and little errors! Maybe it's possible to write a test for duplicates in future.

@jh-RLI jh-RLI changed the title Feature/expand schema Add metadata quility badge-system Apr 11, 2023
@jh-RLI jh-RLI merged commit 17004be into develop Apr 12, 2023
@jh-RLI jh-RLI deleted the feature/expand_schema branch April 12, 2023 11:09
@Ludee Ludee added the type: enhancement ⚙️ Improvement of an existing feature label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ⚙️ Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibilty of schema update for the review process
4 participants