Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFS] Keywords and additional keywords list limited #26

Closed
1 task
han-f opened this issue Apr 6, 2023 · 4 comments
Closed
1 task

[SFS] Keywords and additional keywords list limited #26

han-f opened this issue Apr 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request factsheet 📃 OEP Factsheets

Comments

@han-f
Copy link

han-f commented Apr 6, 2023

Description of the issue

There is a pre-defined list of keywords (study) and additional keywords (scenario). This list is rather limited and some studies or scenarios may not select any. If none is selected the "Keywords:" still shows on the factsheet overview, with no content followed. This may appear as if the users did not bother to provide keywords. I would like to suggest to either not shows "Keywords:" on the overview if none were supplied or to think about how we can better implement the possibility to provide keywords.

Ideas of solution

  1. not show "Keywords:" at all when no entries are available
  2. allow users to choose from a richer list of keywords
  3. allow users to add their own keywords

Workflow checklist

@han-f han-f added the enhancement New feature or request label Apr 6, 2023
@stap-m
Copy link
Contributor

stap-m commented Apr 11, 2023

Thanks for the issue. Are the proposed suggestions exclusive or should they be combined?

  • Regarding option 1: should there me an option "none" if no keywords should be added?
  • Regarding option 2: Please feel free to suggest more keywords.
  • We should discuss option 3 with caution. Is it really required for the factsheets or can we find a cleaner solution? For example: how could we implement a procedure to propose new keywords to the OEKG/OEO?

@stap-m
Copy link
Contributor

stap-m commented Apr 11, 2023

This issue is related to #19

@stap-m stap-m added the factsheet 📃 OEP Factsheets label Apr 11, 2023
@stap-m stap-m changed the title Keywords and additional keywords list limited [SFS] Keywords and additional keywords list limited Apr 11, 2023
@u-mueller
Copy link

Long lists of keywords are the opposite of user friendliness, and suggesting new keywords should be as easy as possible, but I see the point. Maybe we discuss this at the OEKG-Dev meeting tomorrow or on our PM.

@stap-m
Copy link
Contributor

stap-m commented May 2, 2023

EDIT: Notes from SIROP project meeting 2023-04-06:

Distinguish into two cases:
1. missing in factsheet but available in OEO
- add OEO autocomplete descriptors
- define list of OEO autocomplete descriptors #19
2. missing in factsheet and OEO
- guide people through workflow that adds term to the ontology (complicated future work)
- intermediate solution: link to the github oeo new term issue template course in the tutorial section about how to request new oeo terms
- once the composed module is there, give the opportunity to add composed terms

New developments on keywords/descriptors are adressed in #19, that include this issue. Therefore I close this issue now.

@stap-m stap-m closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request factsheet 📃 OEP Factsheets
Projects
None yet
Development

No branches or pull requests

5 participants