-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strange python launcher error when folder has spaces #1627
Conversation
Thanks. I'm a bit hesitant to accept this as a solution, it's my understanding that you're simply forcing users to install ODM to a path without spaces (via shortpath)? I also have concerns about that "Delete Folder" statement (potentially dangerous) and the ASCII encoding requirement (will this even work with non-ASCII characters in the path?) If this issue was fixed in newer versions of Python, can't we just backport the patch? For example, have you attempted to apply pypa/setuptools#2697 ? |
We abandoned the short path workaround in favour of merging the folders |
Need to wait for https://gitlab.com/gitlab-org/gitlab/-/issues/402616 to test this (it's causing the ODM builds to fail).
Not related to the changes here. |
They messed up some hashes 😢 |
Everything checks out, thanks! |
This PR fixes the behavior of innosetup to use the windows short path when it contains spaces.
The issue seems to be related to pypa/setuptools#216 and several others. I tested the same exact setup with newer python versions and they work fine. Unfortunately we are stuck with python 3.8 due to breaking changes in newer versions.
Bonus: added
vcpkg
,venv
,python38
,dist
andinnosetup
folders to gitignore.Closes #1569