-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book configuration - Show section #44
Comments
BTW, when I choose True or False I got the following error in the console Uncaught Error: Syntax error, unrecognized expression: [object HTMLFormElement]input[type='radio']:checked |
I have hidden the show section attribute and will look into the cause of that error. |
I have fixed this error! |
The ability to remove a section has to be restored. We have modules that are deliberately designed to only display one from a choice of sections. In fact, we might consider making a special designation for such modules, so that at configuration time the instructor must pick from a choice. |
What would be the best way to do this? Should I just restore the "showsection" radio button? Or should I try to implement a system that allows you to delete certain sections? |
Taylor -- from your side the only thing to do is to restore the show section radio button. |
I just restored the button! |
This is not fixing my problem. We have it in both the "Plain" and the Canvas books. See the last module in the Algorithm Analysis chapter for CS2 and CS3. CS2 should show ONLY the first exercise,and CS3 should show ONLY the second exercise. The config files specify what should happen. But the compilation process seems to ignore that. |
The compilation process will generate the book html pages under /Books/book_name/html and another set of section level html pages under /Books/book_name/lti_html. The latter folder is used to serve the LTI version while the former is used for plain books. For LTI it should be straightforward when a section is hidden just skip the section file in the course generation step. While in the plain version the compilation process should be changed to entirely remove the hidden sections from a module file. I can take care of LTI version. However, to update the compilation process will need some time to figure it out. |
Just a thought, I could try to add something the configuration view that checks the status of the 'showsection' button and, if it is false, removes that section entirely from the JSON object that I'm sending to the server. Would that fix the problem? Or would it cause issues having the sections not in the configuration? |
This used to work correctly. So the fact that "plain" books are not removing sections means that something happened to break this process. The best approach is that the compilation process will not pass through sections that are not supposed to be there. We don't want to create the HTML files and then "suppress" them somehow. |
Did this get resolved? Unless I'm misunderstanding, this is in the book configuration view and does work now, but I'm not 100% sure |
I was misunderstanding, the book configuration view is broken and most of these need reassessed |
Remove show section attribute for now.
The text was updated successfully, but these errors were encountered: