Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off ES section into a separate add_es_data.sh script (Was: Update add_data.sh script to allow running Postgis and ES sections independently) #99

Open
arashmalekz opened this issue May 12, 2021 · 3 comments
Assignees
Labels
Enhancement New feature or request Task

Comments

@arashmalekz
Copy link
Contributor

We sometimes use Postgis database dumps to populate the database and don't need to run the code in add_data.sh to create Postgis data. It would be useful to have a flag in the .env file to select whether Postgis or ES should be populated or both.

@arashmalekz arashmalekz added the Enhancement New feature or request label May 12, 2021
@anthonyfok anthonyfok added this to the Sprint 34 milestone May 14, 2021
@anthonyfok anthonyfok self-assigned this May 14, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 34, Sprint 35 May 25, 2021
@anthonyfok
Copy link
Member

Hi Arash! Thanks for bringing this up!
This happens to be something related, i.e. trying to resume add_data.sh interruption due to an error or manual abort, or to do some kind of "unit testing", etc., by moving each "section" into individual functions, with build stamp, etc.
And, sorry for the delay! I'll be working on this issue during this Sprint 35. Cheers!

@anthonyfok anthonyfok modified the milestones: Sprint 35, Sprint 36 Jun 7, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 36, Sprint 37 Jun 17, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 37, Sprint 38, Sprint 39 Jul 13, 2021
@anthonyfok anthonyfok changed the title Update add_data.sh script to allow running Postgis and ES sections independently Split of ES section into a separate add_es_data.sh script (Was: Update add_data.sh script to allow running Postgis and ES sections independently) Jul 26, 2021
@anthonyfok
Copy link
Member

Hey @drotheram and @arashmalekz, I'm going to reuse this Issue into splitting off ES sections of add_data.sh into add_es_data.sh, and use this as an excuse for me to split off the helper functions to another separate file.
(Sorry for being dormant for so long!)

@arashmalekz
Copy link
Contributor Author

Great, that split sounds good with me!

@anthonyfok anthonyfok changed the title Split of ES section into a separate add_es_data.sh script (Was: Update add_data.sh script to allow running Postgis and ES sections independently) Split off ES section into a separate add_es_data.sh script (Was: Update add_data.sh script to allow running Postgis and ES sections independently) Jul 27, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 39, Sprint 40 Aug 5, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 40, Sprint 41, Sprint 42 Sep 9, 2021
@jvanulde jvanulde modified the milestones: Sprint 42, Sprint 43 Sep 23, 2021
@anthonyfok anthonyfok removed this from the Sprint 43 milestone Oct 13, 2021
@anthonyfok anthonyfok added this to the Sprint 44 milestone Oct 13, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 44, Sprint 45 Oct 25, 2021
@anthonyfok anthonyfok modified the milestones: Sprint 45, Sprint 47 Nov 22, 2021
@anthonyfok anthonyfok removed this from the Sprint 47 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Task
Projects
None yet
Development

No branches or pull requests

3 participants